[GitHub] [spark] zeruibao commented on a diff in pull request #42503: [SPARK-43380][SQL] Fix Avro data type conversion issues without causing performance regression

["zeruibao (via GitHub)" <gi...@apache.org>]

zeruibao commented on code in PR #42503:
URL: https://github.com/apache/spark/pull/42503#discussion_r1336526095


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -75,6 +75,16 @@
       }
     }
   },
+  "AVRO_INCORRECT_TYPE" : {

Review Comment:
   sure!



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -75,6 +75,16 @@
       }
     }
   },
+  "AVRO_INCORRECT_TYPE" : {
+    "message" : [
+      "Cannot convert Avro <avroPath> to SQL <sqlPath> because the original encoded data type is <avroType>, however you're trying to read the field as <sqlType>, which would lead to an incorrect answer. To allow reading this field, enable the SQL configuration: <key>."

Review Comment:
   sounds good to me!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org