You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/11/08 12:17:56 UTC
[GitHub] carbondata pull request #2909: [CARBONDATA-3089]
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2909
[CARBONDATA-3089]
In case of NO_SORT, currently carbon follows task distribution the same way as
LOCAL_SORT, however, in this case it is better to follow the same task distribution as other file format does.
Thus, this PR change the task distribution as global sort, which depends on CSV input format to get the input split and send task based on compute framework scheduling.
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
run all test
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata nosort_getpartition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2909
----
commit 3d2f70e45e56f50e428c716b234ea64f822edce6
Author: Jacky Li <ja...@...>
Date: 2018-11-08T08:33:36Z
use spark partition for NO_SORT loading
wip
----
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9642/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1561/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1384/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9604/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1334/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2909
Besides, can we gain any benefits from this PR？
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10232/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1543/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2909
Since it is using CSV split in this PR, there are more tasks and each task is smaller, thus we can get better parallelism and require less resource to run in each task
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1545/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1550/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2909
retest this please
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2909
LGTM
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9591/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1346/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2157/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1332/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1339/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9593/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9598/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1547/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2909
retest this please
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1594/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1556/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9595/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2909
retest this please
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1980/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9609/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1351/
---
[GitHub] carbondata issue #2909: [CARBONDATA-3089] Change task distribution for NO_SO...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2909
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1336/
---