[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2227: IGNITE-19745 Added a method for local obtaining entries in MetaStorage from lower bound revision to upper bound revision.

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #2227:
URL: https://github.com/apache/ignite-3/pull/2227#discussion_r1236521082


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -319,6 +321,19 @@ public CompletableFuture<Entry> get(ByteArray key, long revUpperBound) {
         }
     }
 
+    @Override
+    public List<Entry> getEntriesLocally(byte[] key, long revLowerBound, long revUpperBound) {

Review Comment:
   Let's be consistent with other methods naming. There are bunch of method in `MetaStorageManager`, `RocksDbKeyValueStorage` and other related places that return entries, however neither of them have entries in it's name, you on the contrary introduces getEntriesLocally. Please rename it and all related `getEntries`, `doGetEntries`, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org