You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/21 08:38:44 UTC
[GitHub] [inlong] ZuoFengZhang opened a new pull request, #7012: [INLONG-7011][Manager] Check Pulsar non-partition table if exist
ZuoFengZhang opened a new pull request, #7012:
URL: https://github.com/apache/inlong/pull/7012
### Prepare a Pull Request
*[INLONG-7011][Manager] Check Pulsar non-partition table if exist*
- Fixes #7011
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] aloyszhang commented on a diff in pull request #7012: [INLONG-7011][Manager] Check Pulsar non-partition table if exist
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on code in PR #7012:
URL: https://github.com/apache/inlong/pull/7012#discussion_r1054993697
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -292,6 +292,9 @@ public boolean topicExists(PulsarAdmin pulsarAdmin, String tenant, String namesp
}
for (String t : topicList) {
t = t.substring(t.lastIndexOf("/") + 1); // not contains /
+ if (!isPartitioned) {
Review Comment:
Exception cound be thrown if the topic(non-partitioned topic) is not suffixed with `-partition-`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7012: [INLONG-7011][Manager] Check Pulsar non-partition table if exist
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #7012:
URL: https://github.com/apache/inlong/pull/7012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7012: [INLONG-7011][Manager] Check Pulsar non-partition table if exist
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7012:
URL: https://github.com/apache/inlong/pull/7012#discussion_r1054139741
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -292,6 +292,9 @@ public boolean topicExists(PulsarAdmin pulsarAdmin, String tenant, String namesp
}
for (String t : topicList) {
t = t.substring(t.lastIndexOf("/") + 1); // not contains /
+ if (!isPartitioned) {
+ t = t.substring(0, t.lastIndexOf("-partition-"));
Review Comment:
@aloyszhang @lordcheng10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org