You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/01 16:00:38 UTC

[GitHub] [kylin] zhengshengjun opened a new pull request #1594: KYLIN-4919 Use NonShardingReadRDD/ShardingReadRdd automatically for different queries

zhengshengjun opened a new pull request #1594:
URL: https://github.com/apache/kylin/pull/1594


   …ifferent queries
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhengshengjun commented on pull request #1594: KYLIN-4919 Use NonShardingReadRDD/ShardingReadRdd automatically for different queries

Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on pull request #1594:
URL: https://github.com/apache/kylin/pull/1594#issuecomment-788505128


   hi @zzcclp , could you please help me to review this PR ~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhengshengjun closed pull request #1594: KYLIN-4919 Use NonShardingReadRDD/ShardingReadRdd automatically for different queries

Posted by GitBox <gi...@apache.org>.
zhengshengjun closed pull request #1594:
URL: https://github.com/apache/kylin/pull/1594


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhengshengjun commented on pull request #1594: KYLIN-4919 Use NonShardingReadRDD/ShardingReadRdd automatically for different queries

Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on pull request #1594:
URL: https://github.com/apache/kylin/pull/1594#issuecomment-790444392


   thanks you for advice @zzcclp , I'll close this PR and try more cases


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zzcclp commented on a change in pull request #1594: KYLIN-4919 Use NonShardingReadRDD/ShardingReadRdd automatically for different queries

Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1594:
URL: https://github.com/apache/kylin/pull/1594#discussion_r585496298



##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -170,7 +172,8 @@ class FilePruner(cubeInstance: CubeInstance,
   }
 
   private def genShardSpec(selected: Seq[SegmentDirectory]): Option[ShardSpec] = {
-    if (!KylinConfig.getInstanceFromEnv.isShardingJoinOptEnabled || selected.isEmpty) {
+    val isJoinQuery = OLAPContext.getThreadLocalContexts.map(_.allOlapJoins).exists(_.nonEmpty);

Review comment:
       This way is wrong, for example:
   ```
   select XXX from fact_table left join join_table on ... 
   ```
   In this case shown above, the value of 'isJoinQuery' is true, but the join operator will be removed.
   

##########
File path: kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -170,7 +172,8 @@ class FilePruner(cubeInstance: CubeInstance,
   }
 
   private def genShardSpec(selected: Seq[SegmentDirectory]): Option[ShardSpec] = {
-    if (!KylinConfig.getInstanceFromEnv.isShardingJoinOptEnabled || selected.isEmpty) {
+    val isJoinQuery = OLAPContext.getThreadLocalContexts.map(_.allOlapJoins).exists(_.nonEmpty);

Review comment:
       shard join optimization is for joining two or more cubes, but not fact-table joining join-table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org