You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/01/30 14:56:47 UTC

[GitHub] [parquet-mr] wgtmac opened a new pull request, #1021: PARQUET-2229: ParquetRewriter masks and encrypts the same column

wgtmac opened a new pull request, #1021:
URL: https://github.com/apache/parquet-mr/pull/1021

   ### Jira
   
   - My PR addresses [PARQUET-2229](https://issues.apache.org/jira/browse/PARQUET-2229)
   
   ### Tests
   
   - Added ParquetRewriterTest.testNullifyAndEncryptColumn to verify the implementation.
   
   ### Commits
   
   - `ParquetRewriter` supports masking (now only nullify) and encrypting same columns when rewriting files.
   - Remove the restriction off `RewriteOptions`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] wgtmac commented on pull request #1021: PARQUET-2229: ParquetRewriter masks and encrypts the same column

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1021:
URL: https://github.com/apache/parquet-mr/pull/1021#issuecomment-1425179900

   Thanks @ggershinsky and @shangxinli ! Feel good to merge it now?
   
   Also cc @gszadovszky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] wgtmac commented on pull request #1021: PARQUET-2229: ParquetRewriter masks and encrypts the same column

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1021:
URL: https://github.com/apache/parquet-mr/pull/1021#issuecomment-1408889612

   @gszadovszky @ggershinsky @shangxinli Could you help review this? Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli merged pull request #1021: PARQUET-2229: ParquetRewriter masks and encrypts the same column

Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli merged PR #1021:
URL: https://github.com/apache/parquet-mr/pull/1021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #1021: PARQUET-2229: ParquetRewriter masks and encrypts the same column

Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli commented on PR #1021:
URL: https://github.com/apache/parquet-mr/pull/1021#issuecomment-1421322311

   LGTM too. If no other comments, we can merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org