You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2019/02/09 03:04:12 UTC
Clean up worth a branch?
Hi All:
There is a bit of clean up left from a previous branch:
diff --git
a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java
b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java
index 61ced60..6618806 100644
---
a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java
+++
b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java
@@ -87,7 +87,7 @@
}
public RequestHandlerRegistry() {
- this(LOCALHOST, UriPatternType.BASIC);
+ this(LOCALHOST, UriPatternType.URI_PATTERN);
}
private LookupRegistry<T> getPatternMatcher(final String hostname) {
diff --git
a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
index 1ab9c85..35c5625 100644
---
a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
+++
b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/UriPatternType.java
@@ -33,7 +33,7 @@
public enum UriPatternType {
/**
- * @deprecated Use {@link #URI_PATTERN_IN_ORDER}.
+ * @deprecated Use {@link #URI_PATTERN}.
*/
@Deprecated
BASIC,
Is this OK to commit to master or does it need another branch or PR?
Gary
Re: Clean up worth a branch?
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Feb 9, 2019 at 10:46 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Sat, 2019-02-09 at 09:45 -0500, Gary Gregory wrote:
> > On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> >
> > > On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote:
> > > > Hi All:
> > > >
> > > > There is a bit of clean up left from a previous branch:
> > > >
> > >
> > > ...
> > >
> > > >
> > > > Is this OK to commit to master or does it need another branch or
> > > > PR?
> > > >
> > >
> > > There has to be another branch or PR now.
> > >
> > > This just highlights the fact that committing things away to a
> > > release
> > > branch is a bad idea.
> > >
> > > Please create a branch and review the diff prior to merging or ask
> > > someone else to do the review.
> > >
> > > In order to avoid the same mess we had with HTTPCORE-569 and
> > > HTTPCORE-
> > > 570 it might be a good idea to not merge development branches early
> > > and
> > > wait a day in case one might decide to re-work things, do more
> > > cleanups
> > > or add javadocs.
> > >
> >
> > Oleg,
> >
> > Please review branch UriPatternType-cleanup.
> >
> > Thank you,
> > Gary
> >
>
> Looks good to me.
>
> What is the reason for your aversion to using GitHub pull requests that
> enable quite reasonable code review workflow?
>
I had not realized we were on GitBox, sorry. I created a PR.
Gary
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Clean up worth a branch?
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2019-02-09 at 09:45 -0500, Gary Gregory wrote:
> On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
> > On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote:
> > > Hi All:
> > >
> > > There is a bit of clean up left from a previous branch:
> > >
> >
> > ...
> >
> > >
> > > Is this OK to commit to master or does it need another branch or
> > > PR?
> > >
> >
> > There has to be another branch or PR now.
> >
> > This just highlights the fact that committing things away to a
> > release
> > branch is a bad idea.
> >
> > Please create a branch and review the diff prior to merging or ask
> > someone else to do the review.
> >
> > In order to avoid the same mess we had with HTTPCORE-569 and
> > HTTPCORE-
> > 570 it might be a good idea to not merge development branches early
> > and
> > wait a day in case one might decide to re-work things, do more
> > cleanups
> > or add javadocs.
> >
>
> Oleg,
>
> Please review branch UriPatternType-cleanup.
>
> Thank you,
> Gary
>
Looks good to me.
What is the reason for your aversion to using GitHub pull requests that
enable quite reasonable code review workflow?
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Clean up worth a branch?
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote:
> > Hi All:
> >
> > There is a bit of clean up left from a previous branch:
> >
>
> ...
>
> >
> > Is this OK to commit to master or does it need another branch or PR?
> >
>
> There has to be another branch or PR now.
>
> This just highlights the fact that committing things away to a release
> branch is a bad idea.
>
> Please create a branch and review the diff prior to merging or ask
> someone else to do the review.
>
> In order to avoid the same mess we had with HTTPCORE-569 and HTTPCORE-
> 570 it might be a good idea to not merge development branches early and
> wait a day in case one might decide to re-work things, do more cleanups
> or add javadocs.
>
Oleg,
Please review branch UriPatternType-cleanup.
Thank you,
Gary
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Clean up worth a branch?
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote:
> Hi All:
>
> There is a bit of clean up left from a previous branch:
>
...
>
> Is this OK to commit to master or does it need another branch or PR?
>
There has to be another branch or PR now.
This just highlights the fact that committing things away to a release
branch is a bad idea.
Please create a branch and review the diff prior to merging or ask
someone else to do the review.
In order to avoid the same mess we had with HTTPCORE-569 and HTTPCORE-
570 it might be a good idea to not merge development branches early and
wait a day in case one might decide to re-work things, do more cleanups
or add javadocs.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org