You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/04 17:06:00 UTC
[GitHub] [skywalking] codecov-commenter edited a comment on pull request #4816: Provide agent-side meter api
codecov-commenter edited a comment on pull request #4816:
URL: https://github.com/apache/skywalking/pull/4816#issuecomment-633204483
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=h1) Report
> Merging [#4816](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/edd8305fa289cb9d1d9cdbe66920f0fc9e5257d3&el=desc) will **increase** coverage by `0.24%`.
> The diff coverage is `68.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4816 +/- ##
============================================
+ Coverage 51.17% 51.41% +0.24%
- Complexity 2703 2708 +5
============================================
Files 1311 1332 +21
Lines 28577 28827 +250
Branches 3111 3159 +48
============================================
+ Hits 14623 14821 +198
- Misses 13281 13319 +38
- Partials 673 687 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/skywalking/apm/toolkit/meter/Tag.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvVGFnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...pm/toolkit/activation/meter/CounterActivation.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1tZXRlci1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbWV0ZXIvQ291bnRlckFjdGl2YXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apm/toolkit/activation/meter/GaugeActivation.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1tZXRlci1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbWV0ZXIvR2F1Z2VBY3RpdmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../toolkit/activation/meter/HistogramActivation.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1tZXRlci1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbWV0ZXIvSGlzdG9ncmFtQWN0aXZhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/apm/agent/core/meter/Meter.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXIuamF2YQ==) | `16.66% <16.66%> (ø)` | `0.00 <0.00> (?)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | `16.66% <16.66%> (ø)` | `0.00 <0.00> (?)` | |
| [...olkit/activation/meter/util/MeterTagConverter.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXRvb2xraXQtYWN0aXZhdGlvbi9hcG0tdG9vbGtpdC1tZXRlci1hY3RpdmF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2FjdGl2YXRpb24vbWV0ZXIvdXRpbC9NZXRlclRhZ0NvbnZlcnRlci5qYXZh) | `33.33% <33.33%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `45.45% <45.45%> (ø)` | `0.00 <0.00> (?)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | `54.54% <54.54%> (ø)` | `0.00 <0.00> (?)` | |
| [...ing/apm/agent/core/meter/MeterRegistryService.java](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `65.75% <65.75%> (ø)` | `9.00 <9.00> (?)` | |
| ... and [42 more](https://codecov.io/gh/apache/skywalking/pull/4816/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=footer). Last update [edd8305...f198fa7](https://codecov.io/gh/apache/skywalking/pull/4816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org