You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/08/04 12:42:50 UTC
Review Request 37072: Added test for allocator update on scheduler
failover
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2880
https://issues.apache.org/jira/browse/MESOS-2880
Repository: mesos
Description
-------
Added test for allocator update on scheduler failover
Diffs
-----
src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
Diff: https://reviews.apache.org/r/37072/diff/
Testing
-------
make check
Thanks,
Aditi Dixit
Re: Review Request 37072: Added test for allocator update on scheduler
failover
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94050
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37072]
All tests passed.
- Mesos ReviewBot
On Aug. 4, 2015, 10:42 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37072/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 10:42 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for allocator update on scheduler failover
>
>
> Diffs
> -----
>
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/37072/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37072: Added test for allocator update on scheduler
failover
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94104
-----------------------------------------------------------
Nice test!
src/tests/oversubscription_tests.cpp (line 864)
<https://reviews.apache.org/r/37072/#comment148599>
2 blank lines between outer elements.
src/tests/oversubscription_tests.cpp (line 914)
<https://reviews.apache.org/r/37072/#comment148605>
Add a comment here
// Framework doesn't receive revocable resources because
// it doesn't have the capability set.
src/tests/oversubscription_tests.cpp (line 949)
<https://reviews.apache.org/r/37072/#comment148601>
kill extra new line.
src/tests/oversubscription_tests.cpp (line 962)
<https://reviews.apache.org/r/37072/#comment148602>
Space after "//".
src/tests/oversubscription_tests.cpp (lines 975 - 977)
<https://reviews.apache.org/r/37072/#comment148604>
Indent like so:
```
EXPECT_EQ(taskResources + executorResources,
Resources(offers2.get([0].resources()));
````
- Vinod Kone
On Aug. 4, 2015, 10:42 a.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37072/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 10:42 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for allocator update on scheduler failover
>
>
> Diffs
> -----
>
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/37072/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37072: Added test for allocator update on scheduler
failover
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94304
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37072]
All tests passed.
- Mesos ReviewBot
On Aug. 5, 2015, 6:51 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37072/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 6:51 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for allocator update on scheduler failover
>
>
> Diffs
> -----
>
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/37072/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37072: Added test for allocator update on scheduler
failover
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94285
-----------------------------------------------------------
Ship it!
Can you please mark the issues as resolved?
src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/37072/#comment148837>
I would keep the new line. It's a bit dense otherwise.
- Vinod Kone
On Aug. 5, 2015, 6:51 p.m., Aditi Dixit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37072/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 6:51 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for allocator update on scheduler failover
>
>
> Diffs
> -----
>
> src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
>
> Diff: https://reviews.apache.org/r/37072/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Aditi Dixit
>
>
Re: Review Request 37072: Added test for allocator update on scheduler
failover
Posted by Aditi Dixit <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 6:51 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2880
https://issues.apache.org/jira/browse/MESOS-2880
Repository: mesos
Description
-------
Added test for allocator update on scheduler failover
Diffs (updated)
-----
src/tests/oversubscription_tests.cpp c7a2dacb600d7703de6090e7e47f453a3d08b53a
Diff: https://reviews.apache.org/r/37072/diff/
Testing
-------
make check
Thanks,
Aditi Dixit