[jira] [Commented] (SLING-7209) [Topology] Removal of PropertyProvider at runtime does not trigger change event

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210969#comment-16210969 ] 

Stefan Egli commented on SLING-7209:
------------------------------------

Thanks [~dominique.jaeggi]! Regarding involvement of the _ViewStateManagerImpl_ : isn't the core problem rather in [OakDiscoveryService|https://github.com/apache/sling/blob/51eaf62cb6ba5aea236f4798bedddb4d44fa9f88/bundles/extensions/discovery/oak/src/main/java/org/apache/sling/discovery/oak/OakDiscoveryService.java#L518] than in ViewStateManagerImpl?

> [Topology] Removal of PropertyProvider at runtime does not trigger change event
> -------------------------------------------------------------------------------
>
>                 Key: SLING-7209
>                 URL: https://issues.apache.org/jira/browse/SLING-7209
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Dominique Jäggi
>
> When a _PropertyProvider_ is stopped at runtime, causing topology properties to no longer be available, the _ViewStateManagerImpl_ is informed about its removal and compares the old and new view in _#handleNewViewNonDelayed_, doing a _previousView.equals(newView)_.
> This ends up in _DefaultTopologyView_ where known properties are compared with their stored counterparts. A Topology change event is only issued concerning properties if this comparison yields a difference.
> Since the property names of the removed _PropertyProvider_ are no longer part of known properties, their removal is ignored, causing no topology event to be issued and orphaned properties in the repo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)