[jira] [Commented] (HIVE-23258) Remove BoneCP Connection Pool

["Hive QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-23258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088235#comment-17088235 ] 

Hive QA commented on HIVE-23258:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000571/HIVE-23258.1.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17130 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21811/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21811/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21811/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13000571 - PreCommit-HIVE-Build

> Remove BoneCP Connection Pool
> -----------------------------
>
>                 Key: HIVE-23258
>                 URL: https://issues.apache.org/jira/browse/HIVE-23258
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23258.1.patch
>
>
> {quote}
> BoneCP is a Java JDBC connection pool implementation that is tuned for high performance by minimizing lock contention to give greater throughput for your application ... but SHOULD NOW BE CONSIDERED DEPRECATED in favour of HikariCP.
> {quote}
> https://github.com/wwadge/bonecp
> The default in Hive 3.x is already HikariCP, so just remove BoneCP in 4.x
> https://github.com/apache/hive/blob/branch-3.1/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L392



--
This message was sent by Atlassian Jira
(v8.3.4#803005)