You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/01/04 15:28:17 UTC
Review Request 55177: Fixed scheme handling in URL::parse().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Timothy Chen.
Repository: mesos
Description
-------
This method could mistake the host part for the scheme because of
unsuitable use of find_first_of().
Diffs
-----
3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
Diff: https://reviews.apache.org/r/55177/diff/
Testing
-------
Added a test case demonstrating the problem. Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 55177: Fixed scheme handling in URL::parse().
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/#review160637
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55177]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 4, 2017, 3:28 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55177/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 3:28 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method could mistake the host part for the scheme because of
> unsuitable use of find_first_of().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
> 3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
>
> Diff: https://reviews.apache.org/r/55177/diff/
>
>
> Testing
> -------
>
> Added a test case demonstrating the problem. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55177: Fixed scheme handling in URL::parse().
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/#review161107
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 6, 2017, 11:37 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55177/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 11:37 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Timothy Chen.
>
>
> Bugs: MESOS-6871
> https://issues.apache.org/jira/browse/MESOS-6871
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method could mistake the host part for the scheme because of
> unsuitable use of find_first_of().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
> 3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
>
> Diff: https://reviews.apache.org/r/55177/diff/
>
>
> Testing
> -------
>
> Added a test case demonstrating the problem. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55177: Fixed scheme handling in URL::parse().
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/
-----------------------------------------------------------
(Updated Jan. 6, 2017, 11:37 a.m.)
Review request for mesos, Benjamin Mahler and Timothy Chen.
Bugs: MESOS-6871
https://issues.apache.org/jira/browse/MESOS-6871
Repository: mesos
Description
-------
This method could mistake the host part for the scheme because of
unsuitable use of find_first_of().
Diffs
-----
3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
Diff: https://reviews.apache.org/r/55177/diff/
Testing
-------
Added a test case demonstrating the problem. Ran `make check`.
Thanks,
Ilya Pronin
Re: Review Request 55177: Fixed scheme handling in URL::parse().
Posted by Ilya Pronin <ip...@twopensource.com>.
> On Jan. 5, 2017, 11:58 p.m., Timothy Chen wrote:
> > Can you write a JIRA for this and update this review?
Done.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/#review160648
-----------------------------------------------------------
On Jan. 6, 2017, 11:37 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55177/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 11:37 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Timothy Chen.
>
>
> Bugs: MESOS-6871
> https://issues.apache.org/jira/browse/MESOS-6871
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method could mistake the host part for the scheme because of
> unsuitable use of find_first_of().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
> 3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
>
> Diff: https://reviews.apache.org/r/55177/diff/
>
>
> Testing
> -------
>
> Added a test case demonstrating the problem. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55177: Fixed scheme handling in URL::parse().
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55177/#review160648
-----------------------------------------------------------
Can you write a JIRA for this and update this review?
- Timothy Chen
On Jan. 4, 2017, 3:28 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55177/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 3:28 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This method could mistake the host part for the scheme because of
> unsuitable use of find_first_of().
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023
> 3rdparty/libprocess/src/tests/http_tests.cpp d168ad15da4706fb9c3aa11a125b7dfb5987570d
>
> Diff: https://reviews.apache.org/r/55177/diff/
>
>
> Testing
> -------
>
> Added a test case demonstrating the problem. Ran `make check`.
>
>
> Thanks,
>
> Ilya Pronin
>
>