[GitHub] [incubator-druid] gianm commented on issue #7233: Add "is_overshadowed" column to sys.segments table

[GitBox <gi...@apache.org>]

gianm commented on issue #7233: Add "is_overshadowed" column to sys.segments table
URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-481001908
 
 
   @surekhasaharan Can you please add the definition of `is_overshadowed` to the proposal? (To the "Proposed changes" section.) It sounds like we are settling on something like 'published segments that are overshadowed by some other published segment'. I would be fine with it being false for unpublished segments, if that makes it easier to implement. If that's what you do, then just make sure to include it in the docs, please. Maybe document it as something like:
   
   > `is_overshadowed` is true for segments that are published and that are overshadowed by _other_ published segments. Currently, `is_overshadowed` is always false for unpublished segments, although this may change in the future. You can filter for segments that "should be published" by filtering for `is_published = 1 AND is_overshadowed = 0`. Segments can briefly be both published and overshadowed if they were recently replaced, but have not been unpublished yet.
   
   I am ok with leaving `is_published` and `is_available` unchanged, and adding an `is_overshadowed` defined as above. I'm also fine with leaving out active/actual at this time and potentially adding them in a later change. If this is what you're proposing @surekhasaharan then I am 👍  on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org