You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2021/02/25 06:11:25 UTC
[GitHub] [griffin] chitralverma opened a new pull request #589: [WIP] [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
chitralverma opened a new pull request #589:
URL: https://github.com/apache/griffin/pull/589
**What changes were proposed in this pull request?**
_This PR affects only the measure module._
In newer environments specially clouds, Griffin measure module may face compatibility issues due the old Scala and Spark versions. To remedy this following topics are covered in this ticket,
- Cross-compilation across scala major versions (2.11, 2.12)
- Update Spark Version (2.4+)
- Create maven profiles to build different scala and spark versions
- Changes to build strategy
This process is also done is apache spark to build for different versions of Scala and Hadoop.
**Does this PR introduce any user-facing change?**
No
**How was this patch tested?**
Via maven build process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] wankunde commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-789474905
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] asfgit closed pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #589:
URL: https://github.com/apache/griffin/pull/589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-789093549
@wankunde @guoyuepeng Just added support for cross version build against Spark 3.0.2 as well ! 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-788999767
@wankunde spark 3 has some interface changes but let me check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] guoyuepeng commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
guoyuepeng commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-789536973
LGTM!
Thanks guys.
@chitralverma @wankunde
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-789824308
Great, I'll merge this then when I'm back working next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] wankunde commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
wankunde commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-788953867
@chitralverma Hi, chitralverma , I think it's very useful to support cross-version compilation for Scala and Spark dependencies. Since spark 3 has been released for some time, can we support it at the same time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-793592578
merged!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [griffin] chitralverma commented on pull request #589: [GRIFFIN-345] Support cross-version compilation for Scala and Spark dependencies
Posted by GitBox <gi...@apache.org>.
chitralverma commented on pull request #589:
URL: https://github.com/apache/griffin/pull/589#issuecomment-786620924
@wankunde @guoyuepeng please review this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org