You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/27 09:32:36 UTC

[GitHub] [dubbo-go] AlexStocks opened a new pull request #970: upgrade sentinel v1.0.1

AlexStocks opened a new pull request #970:
URL: https://github.com/apache/dubbo-go/pull/970


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. 
   -->
   
   **What this PR does**:
   
   upgrade sentinel-golang to v1.0.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #970: Imp: upgrade sentinel-golang version to v1.0.1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/dubbo-go/pull/970#issuecomment-751569593


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=h1) Report
   > Merging [#970](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=desc) (677d7e8) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8aba19048f5524398d872482603258c16222b71b?el=desc) (8aba190) will **decrease** coverage by `0.16%`.
   > The diff coverage is `25.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/970/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #970      +/-   ##
   ===========================================
   - Coverage    60.06%   59.89%   -0.17%     
   ===========================================
     Files          261      261              
     Lines        12913    12915       +2     
   ===========================================
   - Hits          7756     7736      -20     
   - Misses        4202     4224      +22     
     Partials       955      955              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `63.04% <25.00%> (+0.82%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (-2.18%)` | :arrow_down: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.59%)` | :arrow_down: |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `38.98% <0.00%> (-0.85%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=footer). Last update [8aba190...677d7e8](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #970: Imp: upgrade sentinel-golang version to v1.0.1

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #970:
URL: https://github.com/apache/dubbo-go/pull/970#issuecomment-751569593


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=h1) Report
   > Merging [#970](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=desc) (a976cf4) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8aba19048f5524398d872482603258c16222b71b?el=desc) (8aba190) will **decrease** coverage by `0.14%`.
   > The diff coverage is `25.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/970/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #970      +/-   ##
   ===========================================
   - Coverage    60.06%   59.92%   -0.15%     
   ===========================================
     Files          261      261              
     Lines        12913    12915       +2     
   ===========================================
   - Hits          7756     7739      -17     
   - Misses        4202     4223      +21     
   + Partials       955      953       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `63.04% <25.00%> (+0.82%)` | :arrow_up: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (-2.18%)` | :arrow_down: |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=footer). Last update [8aba190...a976cf4](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #970: Imp: upgrade sentinel-golang version to v1.0.1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #970:
URL: https://github.com/apache/dubbo-go/pull/970#issuecomment-751569593


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=h1) Report
   > Merging [#970](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=desc) (a976cf4) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8aba19048f5524398d872482603258c16222b71b?el=desc) (8aba190) will **decrease** coverage by `0.14%`.
   > The diff coverage is `25.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/970/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #970      +/-   ##
   ===========================================
   - Coverage    60.06%   59.92%   -0.15%     
   ===========================================
     Files          261      261              
     Lines        12913    12915       +2     
   ===========================================
   - Hits          7756     7739      -17     
   - Misses        4202     4223      +21     
   + Partials       955      953       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `63.04% <25.00%> (+0.82%)` | :arrow_up: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (-2.18%)` | :arrow_down: |
   | [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/970/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=footer). Last update [8aba190...677d7e8](https://codecov.io/gh/apache/dubbo-go/pull/970?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #970: Imp: upgrade sentinel-golang version to v1.0.1

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #970:
URL: https://github.com/apache/dubbo-go/pull/970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org