You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/03/17 00:14:24 UTC
Review Request 32134: Kerberos: expose AD config properties in
service > configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32134/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-10096
https://issues.apache.org/jira/browse/AMBARI-10096
Repository: ambari
Description
-------
In Services > Kerberos > Configs UI after setting up Kerb, need to:
- In case of AD, expose LDAP (ldap_url) and DN (container_dn). Currently, these are not exposed so user cannot modify if they need to post-enable Kerberos.
- In case of AD or MIT, "Realm name" should not be editable.
Diffs
-----
ambari-web/app/data/HDP2/site_properties.js a848ade
ambari-web/app/utils/config.js bf0eb81
Diff: https://reviews.apache.org/r/32134/diff/
Testing
-------
Tested the patch manually on kerberized cluster.
**ambari-web unit test result with the patch: **
5575 tests complete (11 seconds)
68 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 32134: Kerberos: expose AD config properties in
service > configs
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32134/#review76674
-----------------------------------------------------------
ambari-web/app/utils/config.js
<https://reviews.apache.org/r/32134/#comment124307>
This can be simplified
- Jaimin Jetly
On March 16, 2015, 11:14 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32134/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 11:14 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-10096
> https://issues.apache.org/jira/browse/AMBARI-10096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Services > Kerberos > Configs UI after setting up Kerb, need to:
>
> - In case of AD, expose LDAP (ldap_url) and DN (container_dn). Currently, these are not exposed so user cannot modify if they need to post-enable Kerberos.
> - In case of AD or MIT, "Realm name" should not be editable.
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2/site_properties.js a848ade
> ambari-web/app/utils/config.js bf0eb81
>
> Diff: https://reviews.apache.org/r/32134/diff/
>
>
> Testing
> -------
>
> Tested the patch manually on kerberized cluster.
>
> **ambari-web unit test result with the patch: **
>
> 5575 tests complete (11 seconds)
> 68 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32134: Kerberos: expose AD config properties in
service > configs
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32134/#review76678
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On March 16, 2015, 11:18 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32134/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 11:18 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-10096
> https://issues.apache.org/jira/browse/AMBARI-10096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Services > Kerberos > Configs UI after setting up Kerb, need to:
>
> - In case of AD, expose LDAP (ldap_url) and DN (container_dn). Currently, these are not exposed so user cannot modify if they need to post-enable Kerberos.
> - In case of AD or MIT, "Realm name" should not be editable.
>
>
> Diffs
> -----
>
> ambari-web/app/data/HDP2/site_properties.js a848ade
> ambari-web/app/utils/config.js bf0eb81
>
> Diff: https://reviews.apache.org/r/32134/diff/
>
>
> Testing
> -------
>
> Tested the patch manually on kerberized cluster.
>
> **ambari-web unit test result with the patch: **
>
> 5575 tests complete (11 seconds)
> 68 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 32134: Kerberos: expose AD config properties in
service > configs
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32134/
-----------------------------------------------------------
(Updated March 16, 2015, 11:18 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-10096
https://issues.apache.org/jira/browse/AMBARI-10096
Repository: ambari
Description
-------
In Services > Kerberos > Configs UI after setting up Kerb, need to:
- In case of AD, expose LDAP (ldap_url) and DN (container_dn). Currently, these are not exposed so user cannot modify if they need to post-enable Kerberos.
- In case of AD or MIT, "Realm name" should not be editable.
Diffs (updated)
-----
ambari-web/app/data/HDP2/site_properties.js a848ade
ambari-web/app/utils/config.js bf0eb81
Diff: https://reviews.apache.org/r/32134/diff/
Testing
-------
Tested the patch manually on kerberized cluster.
**ambari-web unit test result with the patch: **
5575 tests complete (11 seconds)
68 tests pending
Thanks,
Jaimin Jetly