[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #198: [WIP][YUNIKORN-366] Add rest API to update queue configuration

[GitBox <gi...@apache.org>]

TravisBuddy commented on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-core/pull/198#issuecomment-685426596


   ## Travis tests have failed
   
   Hey @kingamarton,
   Please read the following log in order to understand the failure reason.
   It'll be awesome if you fix what's wrong and commit the changes.
   
   
   ### 1st Build
   
   <a href="https:&#x2F;&#x2F;travis-ci.org&#x2F;apache&#x2F;incubator-yunikorn-core&#x2F;jobs&#x2F;723358750">View build log</a>
   
   
   <details>
     <summary>
       <strong>
        curl -sSfL https:&#x2F;&#x2F;raw.githubusercontent.com&#x2F;golangci&#x2F;golangci-lint&#x2F;master&#x2F;install.sh | sh -s -- -b $(go env GOPATH)&#x2F;bin v1.22.2
       </strong>
     </summary>
   
   ```
   golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
   golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
   golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
   ```
   
   </details>
   
   
   <details>
     <summary>
       <strong>
        make lint
       </strong>
     </summary>
   
   ```
   running golangci-lint
   pkg/webservice/dao/config_info.go:27: File is not `gofmt`-ed with `-s` (gofmt)
   	Success bool `json:"success"`
   	Reason string `json:"reason"`
   pkg/plugins/types.go:32: File is not `gofmt`-ed with `-s` (gofmt)
   	configPlugin		   ConfigurationPlugin
   pkg/cache/cluster_info.go:513: File is not `gofmt`-ed with `-s` (gofmt)
   func(m *ClusterInfo) sendUpdatedPartitionsToScheduler(updatedPartitions []*PartitionInfo) *commonevents.Result {
   pkg/webservice/webservice.go:37: File is not `gofmt`-ed with `-s` (gofmt)
   var lock        sync.RWMutex
   pkg/webservice/handlers_test.go:376: File is not `gofmt`-ed with `-s` (gofmt)
   func (f fakeConfigPlugin) UpdateConfiguration (args *si.UpdateConfigurationRequest) *si.UpdateConfigurationResponse {
   pkg/webservice/handlers.go:23: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
   	"go.uber.org/zap"
   	"gopkg.in/yaml.v2"
   pkg/webservice/handlers.go:398: unnecessary trailing newline (whitespace)
   
   	}
   pkg/webservice/handlers.go:367:22: Error return value of `updateConfiguration` is not checked (errcheck)
   		updateConfiguration(oldConf)
   		                   ^
   pkg/webservice/handlers_test.go:474:9: Error return value of `http.NewRequest` is not checked (errcheck)
   			req, _ := http.NewRequest("PUT", "", strings.NewReader(tc.newConf))
   			     ^
   pkg/webservice/handlers.go:395:10: `if` block ends with a `return` statement, so drop this `else` and outdent its block (golint)
   		} else {
   		       ^
   Makefile:45: recipe for target 'lint' failed
   make: *** [lint] Error 1
   ```
   
   </details>
   
   
   ###### TravisBuddy Request Identifier: 7d593320-ecf2-11ea-b6ba-27fe84eba218
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org