You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/30 13:16:24 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2415: Fix of Spring RabbitMQ integration test failures after spring update
JiriOndrusek opened a new pull request #2415:
URL: https://github.com/apache/camel-quarkus/pull/2415
fixes https://github.com/apache/camel-quarkus/issues/2340
I created an issue in quarkus (https://github.com/quarkusio/quarkus/issues/16117).
Once issue is fixed, new buildItem should be used and limitations.adoc could be removed.
I'll create a follow-up issue in camel-quarkus, to take care about it.
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2415: Fix of Spring RabbitMQ integration test failures after spring update
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2415:
URL: https://github.com/apache/camel-quarkus/pull/2415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #2415: Fix of Spring RabbitMQ integration test failures after spring update
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #2415:
URL: https://github.com/apache/camel-quarkus/pull/2415#discussion_r604147286
##########
File path: extensions/spring-rabbitmq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,5 @@
+You can use component without any special configuration in the JVM mode.
Review comment:
Thanks, fixed.
##########
File path: extensions/spring-rabbitmq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,5 @@
+You can use component without any special configuration in the JVM mode.
+
+In native mode you have to add compiler flag `-H:+InlineBeforeAnalysis`,
+to allow removal in static methods (see https://github.com/oracle/graal/issues/2594[graal issue]).
+Component fails without this flag in the native mode.
Review comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2415: Fix of Spring RabbitMQ integration test failures after spring update
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2415:
URL: https://github.com/apache/camel-quarkus/pull/2415#issuecomment-810260507
Follow-up issue: https://github.com/apache/camel-quarkus/issues/2416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2415: Fix of Spring RabbitMQ integration test failures after spring update
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2415:
URL: https://github.com/apache/camel-quarkus/pull/2415#discussion_r604122612
##########
File path: extensions/spring-rabbitmq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,5 @@
+You can use component without any special configuration in the JVM mode.
Review comment:
```suggestion
You can use this extension without any special configuration in JVM mode.
```
##########
File path: extensions/spring-rabbitmq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,5 @@
+You can use component without any special configuration in the JVM mode.
+
+In native mode you have to add compiler flag `-H:+InlineBeforeAnalysis`,
+to allow removal in static methods (see https://github.com/oracle/graal/issues/2594[graal issue]).
+Component fails without this flag in the native mode.
Review comment:
```suggestion
In native mode you need to add
[source,shell]
----
quarkus.native.additional-build-args = -H:+InlineBeforeAnalysis
----
to your `application.properties`. This is to allow inlining of some static methods that would otherwise cause build failures (see this https://github.com/oracle/graal/issues/2594[GraalVM issue]).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org