You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/10/01 05:57:22 UTC
[GitHub] [pulsar-client-go] xujianhai666 commented on a change in pull
request #65: [Issue 64] fix bug: type assert cause panic
xujianhai666 commented on a change in pull request #65: [Issue 64] fix bug: type assert cause panic
URL: https://github.com/apache/pulsar-client-go/pull/65#discussion_r329888718
##########
File path: pulsar/impl_partition_producer.go
##########
@@ -293,14 +293,17 @@ func (p *partitionProducer) internalFlushCurrentBatch() {
func (p *partitionProducer) internalFlush(fr *flushRequest) {
p.internalFlushCurrentBatch()
- pi := p.pendingQueue.PeekLast().(*pendingItem)
Review comment:
In point of my view, if type is specific, meaning the item from pendingQueue is *pendingItem, we can not type assert with ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services