[GitHub] dangogh commented on a change in pull request #2534: Fix DSR PUT handlers for status/assignments

[GitBox <gi...@apache.org>]

dangogh commented on a change in pull request #2534: Fix DSR PUT handlers for status/assignments
URL: https://github.com/apache/trafficcontrol/pull/2534#discussion_r202167839
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/request/requests.go
 ##########
 @@ -486,7 +486,9 @@ func (req *deliveryServiceRequestAssignment) Update() (error, tc.ApiErrorType) {
 
 	// Only assigneeID changes -- nothing else
 	assigneeID := req.AssigneeID
+	reqInfo := req.ReqInfo // save the ReqInfo
 	*req = deliveryServiceRequestAssignment{current}
+	req.ReqInfo = reqInfo
 	req.AssigneeID = assigneeID
 
 Review comment:
   it was saving everything from the current DS request from the db and updating only the assignment.  Now there's an extra layer,  but this could be restored doing: 
   ```	assigneeID := req.AssigneeID
   	req.DeliveryServiceRequestNullable = current.DeliveryServiceRequestNullable
   	req.AssigneeID = assigneeID
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services