You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2021/11/09 07:48:32 UTC

[Bug 65674] New: Missing check if PictureShape contains video

https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

            Bug ID: 65674
           Summary: Missing check if PictureShape contains video
           Product: POI
           Version: 5.0.x-dev
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: XSLF
          Assignee: dev@poi.apache.org
          Reporter: vadim.zav@storied.co
  Target Milestone: ---

Recently I needed to check if Picture on a slide is actually embedded video, so
I implemented method isSetVideoFile() of XSLFPictureShape instance.
Also added method for getting Link attribute to video.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 65674] Missing check if PictureShape contains video

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
Thanks - I added r1894860 - I renamed your methods a little - if you feel
strongly about the method comments, please get back to us

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 65674] Missing check if PictureShape contains video

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

--- Comment #1 from Vadim <va...@storied.co> ---
Created attachment 38083
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38083&action=edit
Patch with a test presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 65674] Missing check if PictureShape contains video

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

Vadim <va...@storied.co> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38083|Patch with a test           |Patch with a test
        description|presentation                |presentation file

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 65674] Missing check if PictureShape contains video

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

Roman Melnik <ro...@storied.co> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
                 CC|                            |roman.melnik@storied.co

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 65674] Missing check if PictureShape contains video

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65674

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Dominik Stadler <do...@gmx.at> ---
Setting to resolved as the core change is done now, please reopen if there is
still something missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org