You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/12/04 21:03:19 UTC
Re: Review Request 63492: Synchronized agent resource versions via
'UpdateSlaveMessage'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/#review192759
-----------------------------------------------------------
src/master/master.hpp
Lines 270 (patched)
<https://reviews.apache.org/r/63492/#comment271018>
How about a comment explaining what this is for the uninitiated?
- Benjamin Mahler
On Nov. 7, 2017, 10 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63492/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 10 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit introduces agent resource versions to the master and
> agents. Agents are responsible for maintaining their resource
> versions. The resource versions are synchronized with the master via
> 'UpdateSlaveMessage'.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 95f57da820db676874302f1c3138a76c22a88593
> src/common/protobuf_utils.cpp 7a4b87becbe73f0fa97ebceee6b71ede8dce90dd
> src/master/master.hpp 0c1253aa1a88d113d42ce362d6992ad84217728c
> src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c
> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7
> src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1
>
>
> Diff: https://reviews.apache.org/r/63492/diff/6/
>
>
> Testing
> -------
>
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>