You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "resyfer (via GitHub)" <gi...@apache.org> on 2024/10/22 17:11:55 UTC

[PR] fs/mnemofs: Fix extra log unused value error. [nuttx]

resyfer opened a new pull request, #14463:
URL: https://github.com/apache/nuttx/pull/14463

   Fix the unused value error for when extra logs are OFF.
   
   ## Summary
   
   This PR fixes the unused value error when extra logs are configured to be OFF in mnemofs. This issue occurs because initially the `MFS_EXTRA_LOG` was defined to be nothing when configured OFF, but configured to be `finfo` when turned on.
   
   This meant when it was OFF, the contents inside the `()` were still present, but without the macro wrapper, which caused the compilation error.
   
   ## Impact
   
   The users can now turn OFF the extra logs without compilation errors.
   
   ## Testing
   
   The error was recognized by [this GitHub action](https://github.com/apache/nuttx/actions/runs/11459507141/job/31884231071?pr=14449).
   
   I confirm that changes are verified on local setup and works as intended:
   
   Build Host(s): OS (Linux), CPU(Intel), compiler(GCC 13).
   Target(s): arch(sim), sim:mnemofs.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fs/mnemofs: Fix extra log unused value error. [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #14463:
URL: https://github.com/apache/nuttx/pull/14463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fs/mnemofs: Fix extra log unused value error. [nuttx]

Posted by "resyfer (via GitHub)" <gi...@apache.org>.
resyfer commented on PR #14463:
URL: https://github.com/apache/nuttx/pull/14463#issuecomment-2429827239

   @xiaoxiang781216 Here's the CI fix to #14445.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org