You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/01/26 01:35:47 UTC
Review Request 17359: Avoid using protobuf equals().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17359/
-----------------------------------------------------------
Review request for Aurora and Joe Smith.
Repository: aurora
Description
-------
Avoid using protobuf equals().
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java e4a22594f7f0288afd38d88ba32f4beff6028510
Diff: https://reviews.apache.org/r/17359/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 17359: Avoid using protobuf equals().
Posted by Jonathan Boulle <jo...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17359/#review32787
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Boulle
On Jan. 26, 2014, 12:35 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17359/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2014, 12:35 a.m.)
>
>
> Review request for Aurora and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoid using protobuf equals().
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java e4a22594f7f0288afd38d88ba32f4beff6028510
>
> Diff: https://reviews.apache.org/r/17359/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17359: Avoid using protobuf equals().
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17359/#review32788
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Jan. 25, 2014, 4:35 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17359/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 4:35 p.m.)
>
>
> Review request for Aurora and Joe Smith.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoid using protobuf equals().
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java e4a22594f7f0288afd38d88ba32f4beff6028510
>
> Diff: https://reviews.apache.org/r/17359/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>