You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/11 20:48:33 UTC

[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3076: [GOBBLIN-1230] add option to add spec executor configs to gaas job

arjun4084346 commented on a change in pull request #3076:
URL: https://github.com/apache/incubator-gobblin/pull/3076#discussion_r487283604



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -165,6 +171,8 @@ private static void addAdditionalConfig(JobSpec jobSpec, Config sysConfig) {
 
       Config config = jobSpec.getConfig().withFallback(ConfigUtils.getConfigOrEmpty(sysConfig, additionalConfigsPrefix));
 
+      config = config.withFallback(ConfigUtils.getConfigOrEmpty(specExecutorConfig, additionalConfigsPrefix));

Review comment:
       It will be dropped, i.e. will return b




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org