You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/09/08 15:59:08 UTC

[GitHub] [superset] michael-s-molina opened a new issue, #25234: Bugs with the currency format control

michael-s-molina opened a new issue, #25234:
URL: https://github.com/apache/superset/issues/25234

   While testing the currency format control I found some bugs:
   
   **When you clear the currency format, the changes are not reflected in the viz.**
   
   https://github.com/apache/superset/assets/70410625/12e5847f-8cff-4ce6-a406-ba864efd0987
   
   https://github.com/apache/superset/assets/70410625/a363cef3-442d-42d6-9d02-2f99a55fb4dc
   
   These are just examples for Table and Pivot Table but we should check all supported charts for this problem. It seems the control is not handling the Select `onClear` event.
   
   Currency format is not working for the Table chart when in Raw Records mode.
   
   https://github.com/apache/superset/assets/70410625/7e9609f6-bf71-4103-9bb0-f954fdb2e4db
   
   ### Environment
   
   - superset version: `master`
   
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on issue #25234: Bugs with the currency format control

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on issue #25234:
URL: https://github.com/apache/superset/issues/25234#issuecomment-1712828332

   Fix for the treemap bug: https://github.com/apache/superset/pull/25249
   Fix for raw table: https://github.com/apache/superset/pull/25248


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #25234: Bugs with the currency format control

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25234:
URL: https://github.com/apache/superset/issues/25234#issuecomment-1712165468

   @kgabryje I fixed the problem with clearing the Currency Format [here](https://github.com/apache/superset/pull/25238).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #25234: Bugs with the currency format control

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25234:
URL: https://github.com/apache/superset/issues/25234#issuecomment-1711922873

   TreeMap seems to be formatting the dimensions, which differs from the other chart types. 
   
   <img width="1471" alt="Screenshot 2023-09-08 at 13 14 42" src="https://github.com/apache/superset/assets/70410625/bf66ae44-fe1c-471a-b581-02b3798571b8">
   
   For example, the PieChart preserves the Year format and only formats metrics.
   
   <img width="1483" alt="Screenshot 2023-09-08 at 13 16 01" src="https://github.com/apache/superset/assets/70410625/603d0c74-27f4-4498-a45a-da10073896ac">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina closed issue #25234: Bugs with the currency format control

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #25234: Bugs with the currency format control
URL: https://github.com/apache/superset/issues/25234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #25234: Bugs with the currency format control

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25234:
URL: https://github.com/apache/superset/issues/25234#issuecomment-1711898654

   @sadpandajoe @jinghua-qa 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #25234: Bugs with the currency format control

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25234:
URL: https://github.com/apache/superset/issues/25234#issuecomment-1714044589

   Closed by the referenced PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org