You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/03 20:02:24 UTC

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions

michaeljmarshall commented on a change in pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#discussion_r777659034



##########
File path: .gitignore
##########
@@ -16,3 +16,6 @@ charts/**/*.lock
 
 PRIVATEKEY
 PUBLICKEY
+.vagrant/
+pulsarctl-amd64-linux.tar.gz
+pulsarctl-amd64-linux/

Review comment:
       I looked at my clone of the project, and I can see that I have `pulsarctl-amd64-darwin/` and `pulsarctl-amd64-darwin.tar.gz`. These names must be arch dependent.
   
   Why do we need these files/directories though? From what I can tell, it is because the tests use it to generate tokens/keys. It seems like we could use a more standard tool, like `openssl`, for token generation and then drop this dependency.
   
   If we want to worry about the dependency in another PR/thread, I think you could update this to `pulsarctl-**` for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org