[GitHub] andrzej-kaczmarek opened a new pull request #1236: sys/console: Add proper flow control

[GitBox <gi...@apache.org>]

andrzej-kaczmarek opened a new pull request #1236: sys/console: Add proper flow control
URL: https://github.com/apache/mynewt-core/pull/1236
 
 
   sys/console: Add proper flow control
       
   Flow control in console was pretty much non-existent since we always returned success from console_handle_char(). This means there was no way for "character source" to apply some kind of flow control.
       
   To fix this console has to know when new line events are put back to queue which means queue of available line events has to be handled by console itself, not by the client. In case there is no free line event available to handle new character, RX is stalled in console and resumed when new line event is put back to queue. This automatically triggers flow control on UART, if enabled (otherwise we'll just drop characters, but this is "works as designed").
       
   The above also works well with asynchronous UART RX since we no longer remove "oldest" character from queue in case of overflow, but just trigger UART flow control instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services