You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/17 20:55:58 UTC

[GitHub] [druid] samarthjain commented on a change in pull request #10040: Druid Avatica - Handle escaping of search characters correctly

samarthjain commented on a change in pull request #10040:
URL: https://github.com/apache/druid/pull/10040#discussion_r441828906



##########
File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java
##########
@@ -446,15 +446,16 @@ public MetaResultSet getColumns(
     }
 
     if (schemaPattern.s != null) {
-      whereBuilder.add("COLUMNS.TABLE_SCHEMA LIKE " + Calcites.escapeStringLiteral(schemaPattern.s));

Review comment:
       Thanks for taking a look, @gianm . Pushed a commit to add the `ESCAPE` clause in the three methods along with tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org