[GitHub] [cassandra] krummas commented on a diff in pull request #1767: CASSANDRA-17800: Add UUID to nodetool import logging

[GitBox <gi...@apache.org>]

krummas commented on code in PR #1767:
URL: https://github.com/apache/cassandra/pull/1767#discussion_r940088106


##########
src/java/org/apache/cassandra/db/SSTableImporter.java:
##########
@@ -170,11 +171,13 @@ synchronized List<String> importNewSSTables(Options options)
 
         if (newSSTables.isEmpty())
         {
-            logger.info("No new SSTables were found for {}/{}", cfs.keyspace.getName(), cfs.getTableName());
+            logger.info("[{}] No new SSTables were found for {}/{}", importID, cfs.keyspace.getName(), cfs.getTableName());
             return failedDirectories;
         }
 
-        logger.info("Loading new SSTables and building secondary indexes for {}/{}: {}", cfs.keyspace.getName(), cfs.getTableName(), newSSTables);
+        logger.info("[{}] Loading new SSTables and building secondary indexes for {}/{}: {}", importID, cfs.keyspace.getName(), cfs.getTableName(), newSSTables);
+        if (logger.isDebugEnabled())

Review Comment:
   this should probably be `isTraceEnabled` here since debug is on by default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org