You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/07 05:38:32 UTC
[kudu-CR] WIP: DeltaIterator::SelectUpdates
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11137
to review the following change.
Change subject: WIP: DeltaIterator::SelectUpdates
......................................................................
WIP: DeltaIterator::SelectUpdates
WIP because this needs deltafile tests. I started to implement them in a
later commit.
Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
---
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
8 files changed, 160 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/11137/1
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] deltas: add SelectUpdates iterator method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11137 )
Change subject: deltas: add SelectUpdates iterator method
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] deltas: add SelectUpdates iterator method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11137 )
Change subject: deltas: add SelectUpdates iterator method
......................................................................
Patch Set 6: Verified+1
Overriding Jenkins, unrelated test failure (filed KUDU-2550).
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 16:30:16 +0000
Gerrit-HasComments: No
[kudu-CR] deltas: add SelectUpdates iterator method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11137 )
Change subject: deltas: add SelectUpdates iterator method
......................................................................
Abandoned
Ended up merging this into another change, because it made more sense to do so.
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] deltas: add SelectUpdates iterator method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11137
to look at the new patch set (#7).
Change subject: deltas: add SelectUpdates iterator method
......................................................................
deltas: add SelectUpdates iterator method
Like ApplyUpdates and ApplyDeletes, SelectUpdates shares similar semantics:
1. It takes a SelectionVector as input (though unlike ApplyDeletes, it
expects it to be entirely unset).
2. It iterates over all relevant updates, setting the row if there's an
update for it.
This will be used in incremental backup "diff scans".
Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
---
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/tablet-test-util.h
10 files changed, 187 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/11137/7
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] deltas: add SelectUpdates iterator method
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11137
to look at the new patch set (#2).
Change subject: deltas: add SelectUpdates iterator method
......................................................................
deltas: add SelectUpdates iterator method
Like ApplyUpdates and ApplyDeletes, SelectUpdates shares similar semantics:
1. It takes a SelectionVector as input (though unlike ApplyDeletes, it
expects it to be entirely unset).
2. It iterates over all relevant updates, setting the row if there's an
update for it.
This will be used in incremental backup "diff scans".
Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
---
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/tablet-test-util.h
10 files changed, 188 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/11137/2
--
To view, visit http://gerrit.cloudera.org:8080/11137
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5dda1787b8dfa64bc86800b8883499929eef9fef
Gerrit-Change-Number: 11137
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>