You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/09/14 17:07:01 UTC

[jira] [Commented] (PHOENIX-4211) Change tephra dependency in phoenix-kafka to test dependency like other poms

    [ https://issues.apache.org/jira/browse/PHOENIX-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166605#comment-16166605 ] 

Josh Elser commented on PHOENIX-4211:
-------------------------------------

+1 yup, looks like it to me. {{mvn dependency:analyze}} can be a helpful tool here too:

{noformat}
[INFO] --- maven-dependency-plugin:2.1:analyze (default-cli) @ phoenix-kafka ---
[WARNING] Used undeclared dependencies found:
[WARNING]    com.101tec:zkclient:jar:0.7:compile
[WARNING]    org.apache.flume:flume-ng-sdk:jar:1.4.0:compile
[WARNING]    org.apache.flume:flume-ng-configuration:jar:1.4.0:compile
[WARNING]    commons-cli:commons-cli:jar:1.2:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.apache.tephra:tephra-api:jar:0.12.0-incubating:compile
[WARNING]    org.apache.tephra:tephra-core:jar:0.12.0-incubating:compile
[WARNING]    org.apache.tephra:tephra-core:test-jar:tests:0.12.0-incubating:test
[WARNING]    org.apache.tephra:tephra-hbase-compat-1.1:jar:0.12.0-incubating:compile
[WARNING]    org.antlr:antlr-runtime:jar:3.5.2:compile
[WARNING]    jline:jline:jar:2.11:compile
[WARNING]    sqlline:sqlline:jar:1.2.0:compile
[WARNING]    joda-time:joda-time:jar:1.6:compile
[WARNING]    com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile
[WARNING]    com.github.stephenc.jcip:jcip-annotations:jar:1.0-1:compile
[WARNING]    org.codehaus.jackson:jackson-core-asl:jar:1.9.2:compile
[WARNING]    org.codehaus.jackson:jackson-mapper-asl:jar:1.9.2:compile
[WARNING]    org.codehaus.jackson:jackson-jaxrs:jar:1.9.2:test
[WARNING]    org.codehaus.jackson:jackson-xc:jar:1.9.2:test
[WARNING]    org.mockito:mockito-all:jar:1.8.5:test
[WARNING]    com.google.protobuf:protobuf-java:jar:2.5.0:compile
[WARNING]    org.apache.httpcomponents:httpclient:jar:4.0.1:compile
[WARNING]    log4j:log4j:jar:1.2.17:compile
[WARNING]    org.iq80.snappy:snappy:jar:0.3:compile
[WARNING]    com.github.stephenc.high-scale-lib:high-scale-lib:jar:1.1.1:test
[WARNING]    com.yammer.metrics:metrics-core:jar:2.1.2:test
[WARNING]    com.lmax:disruptor:jar:3.2.0:test
[WARNING]    org.apache.htrace:htrace-core:jar:3.1.0-incubating:compile
[WARNING]    io.netty:netty-all:jar:4.0.23.Final:compile
[WARNING]    commons-codec:commons-codec:jar:1.7:compile
[WARNING]    commons-collections:commons-collections:jar:3.2.2:compile
[WARNING]    org.apache.commons:commons-csv:jar:1.0:compile
[WARNING]    com.google.code.findbugs:jsr305:jar:2.0.1:compile
[WARNING]    org.apache.hbase:hbase-testing-util:jar:1.3.1:test
[WARNING]    org.apache.hbase:hbase-it:test-jar:tests:1.3.1:test
[WARNING]    org.apache.hbase:hbase-annotations:jar:1.3.1:compile
[WARNING]    org.apache.hbase:hbase-common:test-jar:tests:1.3.1:test
[WARNING]    org.apache.hbase:hbase-protocol:jar:1.3.1:compile
[WARNING]    org.apache.hbase:hbase-client:jar:1.3.1:compile
[WARNING]    org.apache.hbase:hbase-server:jar:1.3.1:compile
[WARNING]    org.apache.hbase:hbase-server:test-jar:tests:1.3.1:test
[WARNING]    org.apache.hbase:hbase-hadoop-compat:jar:1.3.1:compile
[WARNING]    org.apache.hbase:hbase-hadoop-compat:test-jar:tests:1.3.1:test
[WARNING]    org.apache.hbase:hbase-hadoop2-compat:jar:1.3.1:test
[WARNING]    org.apache.hbase:hbase-hadoop2-compat:test-jar:tests:1.3.1:test
[WARNING]    org.apache.hadoop:hadoop-annotations:jar:2.7.1:compile
[WARNING]    org.apache.hadoop:hadoop-mapreduce-client-core:jar:2.7.1:compile
[WARNING]    org.apache.hadoop:hadoop-minicluster:jar:2.7.1:test
[WARNING]    org.apache.hadoop:hadoop-minikdc:jar:2.7.1:test
[WARNING]    org.jruby.joni:joni:jar:2.1.2:compile
[WARNING]    org.apache.phoenix:phoenix-core:jar:4.12.0-HBase-1.3-SNAPSHOT:compile
[WARNING]    org.apache.phoenix:phoenix-core:jar:tests:4.12.0-HBase-1.3-SNAPSHOT:test
[WARNING]    org.apache.kafka:kafka-clients:jar:test:0.9.0.0:test
[WARNING]    org.apache.kafka:kafka-tools:jar:0.9.0.0:compile
[WARNING]    org.apache.phoenix:phoenix-flume:jar:4.12.0-HBase-1.3-SNAPSHOT:compile
[WARNING]    org.apache.flume:flume-ng-core:jar:1.4.0:compile
{noformat}

That tool also calls it out that those dependencies (among others) are included unnecessarily. Admittedly, sometimes this tool is unable to reason about runtime dependencies (it only looks at compilation), so it's a "recommendation" :)

> Change tephra dependency in phoenix-kafka to test dependency like other poms
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-4211
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4211
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4211.patch
>
>
> In upgrading to Tephra 0.13, I noticed that the phoenix-kafka/pom.xml was different than others wrt Tephra. Seems like it should be consistent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)