You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/16 04:25:33 UTC

[GitHub] [incubator-superset] junlincc opened a new issue #11299: Usability - button color and styling

junlincc opened a new issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299


   <img width="831" alt="Screen Shot 2020-10-15 at 9 04 53 PM" src="https://user-images.githubusercontent.com/67837651/96212020-a23ecd80-0f2a-11eb-8f88-fa26193be3ce.png">
   
   Let's change the data viz select button's color - from grey to CTA colors like blue; please consider changing the button styling below as well. There are a few others in the explore control panel. We should get to them all gradually. @rusackas 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-709743474


   Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-714215203


   You have to pick a dataset!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-714217281


   <img width="436" alt="Screen Shot 2020-10-21 at 9 31 17 PM" src="https://user-images.githubusercontent.com/487433/96824895-c7c54e80-13e4-11eb-880c-f73361bd13f5.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-710207345


   ![Pasted_Image_10_16_20__9_46_AM](https://user-images.githubusercontent.com/812905/96285976-896b0200-0f94-11eb-9c6d-f3d8d786081d.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-710206992


   ![Uploading Pasted_Image_10_16_20__9_46_AM.png…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-714215548


   Though the disabled styling isn't super accessible, maybe we can make the text a little darker.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch closed issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
mistercrunch closed issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas removed a comment on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
rusackas removed a comment on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-710206992


   ![Uploading Pasted_Image_10_16_20__9_46_AM.png…]()
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11299: Usability - button color and styling

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11299:
URL: https://github.com/apache/incubator-superset/issues/11299#issuecomment-714218870


   I think as soon as the users select a dataset, the pill color should turn
   blue.
   
   On Wed, Oct 21, 2020 at 9:31 PM Maxime Beauchemin <no...@github.com>
   wrote:
   
   > [image: Screen Shot 2020-10-21 at 9 31 17 PM]
   > <https://user-images.githubusercontent.com/487433/96824895-c7c54e80-13e4-11eb-880c-f73361bd13f5.png>
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-superset/issues/11299#issuecomment-714217281>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AQFR5U5QL3WLSMARWLRKADDSL6YTBANCNFSM4SS2MOLA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org