You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/25 12:33:42 UTC

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6914: [IOTDB-3164] Manage the memory of cross space compaction in write memory controller

qiaojialin commented on code in PR #6914:
URL: https://github.com/apache/iotdb/pull/6914#discussion_r954909864


##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/rewrite/RewriteCrossSpaceCompactionSelector.java:
##########
@@ -56,6 +75,223 @@ public RewriteCrossSpaceCompactionSelector(
     this.dataRegionId = dataRegionId;
     this.timePartition = timePartition;
     this.tsFileManager = tsFileManager;
+    this.memoryBudget = config.getCrossCompactionMemoryBudget();

Review Comment:
   apply this memory from the storage engine, not from the whole system



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org