You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2011/08/09 17:53:25 UTC
svn commit: r1155415 -
/incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java
Author: andy
Date: Tue Aug 9 15:53:24 2011
New Revision: 1155415
URL: http://svn.apache.org/viewvc?rev=1155415&view=rev
Log:
JENA-91 Early check for silly buffer allocation.
Modified:
incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java
Modified: incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java
URL: http://svn.apache.org/viewvc/incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java?rev=1155415&r1=1155414&r2=1155415&view=diff
==============================================================================
--- incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java (original)
+++ incubator/jena/Experimental/TxTDB/trunk/src/main/java/com/hp/hpl/jena/tdb/base/objectfile/ObjectFileStorage.java Tue Aug 9 15:53:24 2011
@@ -246,6 +246,14 @@ public class ObjectFileStorage implement
if ( x != 4 )
throw new FileException("ObjectFile.read("+loc+")["+filesize+"]["+file.size()+"]: Failed to read the length : got "+x+" bytes") ;
int len = lengthBuffer.getInt(0) ;
+ // Sanity check.
+ if ( len > filesize-(loc+SizeOfInt) )
+ {
+ String msg = "ObjectFile.read("+loc+")["+filesize+"]["+file.size()+"]: Impossibly large object : "+len+" bytes" ;
+ SystemTDB.errlog.error(msg) ;
+ throw new FileException(msg) ;
+ }
+
ByteBuffer bb = ByteBuffer.allocate(len) ;
x = file.read(bb, loc+SizeOfInt) ;
bb.flip() ;