[jira] [Comment Edited] (TS-2766) HdrHeap::coalesce_str_heaps doesn't properly calculate new heap size

["Brian Geffon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996605#comment-13996605 ] 

Brian Geffon edited comment on TS-2766 at 5/13/14 4:46 PM:
-----------------------------------------------------------

Phil, please also include https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=commitdiff;h=02cc2aa5400527af365084e4bc66f16f4d61f4d2, we don't want to alter the ronly heaps and str_heap default size. This commit will undo those changes.


was (Author: briang):
Phil, please also include https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=commitdiff;h=02cc2aa5400527af365084e4bc66f16f4d61f4d2, we don't want to alter the ronly heaps and str_heap default size.

> HdrHeap::coalesce_str_heaps doesn't properly calculate new heap size
> --------------------------------------------------------------------
>
>                 Key: TS-2766
>                 URL: https://issues.apache.org/jira/browse/TS-2766
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 4.2.1, 5.0.0
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 5.0.0
>
>
> HdrHeap::coalesce_str_heaps doesn't properly calculate the new heap size for a few reasons:
>  1) It doesn't current walk the HdrHeap chain (m_next).
>  2) It doesn't account for HdrHeap objects that point to the same string in the HdrStrHeap.
> The easiest fix for this is to completely walk all of the HdrHeap objects in the chain and sum up the size of every string; obviously this approach means that strings that were previously aliased will now become independent copies on coalesce; however, the alternative solution that allows continued aliasing would be pretty messy.
> I'm proposing we just properly determine the size but allow the user to minimizing coalescing by making the read only heap sizes configurable and the StrHdrHeap and HdrHeap default sizes configurable.



--
This message was sent by Atlassian JIRA
(v6.2#6252)