[GitHub] [flink] kl0u opened a new pull request #10528: [FLINK-15179] Kubernetes Session CLI use generic ExecutorCLI, not custom one

[GitBox <gi...@apache.org>]

kl0u opened a new pull request #10528: [FLINK-15179] Kubernetes Session CLI use generic ExecutorCLI, not custom one
URL: https://github.com/apache/flink/pull/10528
 
 
   ## What is the purpose of the change
   
   As part of FLIP-73, all command line options are mapped to config options. Given this 1-to-1 mapping, the `Kubernetes` command line could simply forward the command line arguments to `ConfigOptions` directly, instead of introducing new command line options. In this case, the user is expected to simply write:
   
   ```bin/run -e (or --executor) kubernetes-session-cluster -D kubernetes.container.image=MY_IMAGE ... ```
   
   and the CLI will parse the `-e` to figure out the correct `ClusterClientFactory` and `ExecutorFactory` and then forward to that the config options specified with `-D`. 
   
   For this, we introduce the `ExecutorCLI` that simply forward the specified parameters to the `Executors`. 
   
   ## Brief change log
   
     - *Introduce the `ExecutorCLI`*
     - *Partially remove the `FlinkKubernetesCustomCli` and make it use the new `ExecutorCLI`*
   
   ## Verifying this change
   
   This change covered by existing tests that have been adapted to account for the changes, mainly the `KubernetesSessionCliTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (will come in a future JIRA)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services