[GitHub] [incubator-superset] summerswallow-whi commented on issue #10063: Can we achieve "adding prefix to all superset routes" ?

[GitBox <gi...@apache.org>]

summerswallow-whi commented on issue #10063:
URL: https://github.com/apache/incubator-superset/issues/10063#issuecomment-657677818


   I'm very interested in this issue. Seems from what I've read, that for some organization this could be a make or break reason to use Superset as might be the case for my organization as well. Seeing what transpired in the PR#3690. I would suggest multiple PR. I think the part of the reason it failed is because they were trying to fix the whole problem at once and since the project progressed with hundreds of PR during the time resolving conflicts became a great burden. 
   
   Seems that even if all the PR does is converts to `flask.url_for` that is a better coding practice than hard coded paths could be the first PR. This would be a code quality enhancement rather than feature enhancement. Once in you start taking on the next problem. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org