You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/01/15 17:58:32 UTC
Review Request 29930: Cleaned up namespace hierarchy in allocation
sources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29930/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/allocation/allocator.hpp PRE-CREATION
src/allocation/drf_sorter.hpp PRE-CREATION
src/allocation/drf_sorter.cpp PRE-CREATION
src/allocation/hierarchical_allocator.hpp PRE-CREATION
src/allocation/sorter.hpp PRE-CREATION
src/local/local.hpp 0aa50ef
src/local/local.cpp 76e73a4
src/master/main.cpp 193d53f
src/master/master.hpp 6ccfb79
src/master/master.cpp 385df85
src/tests/cluster.hpp 74cedb3
src/tests/fault_tolerance_tests.cpp 5763486
src/tests/hierarchical_allocator_tests.cpp 7c05123
src/tests/master_allocator_tests.cpp 2430622
src/tests/master_authorization_tests.cpp 42ffe24
src/tests/master_tests.cpp 678d27f
src/tests/mesos.hpp 591134b
src/tests/mesos.cpp 3b98c69
src/tests/partition_tests.cpp fea7801
src/tests/rate_limiting_tests.cpp 7f5ca25
src/tests/resource_offers_tests.cpp d098e70
src/tests/slave_recovery_tests.cpp 809822e
src/tests/sorter_tests.cpp 56e5714
Diff: https://reviews.apache.org/r/29930/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29930: Cleaned up namespace hierarchy in allocation
sources.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29930/#review68565
-----------------------------------------------------------
I am still not entirely convinced if the name space should not be master::allocator and the dir in src/master/allocator. Is the moduleness driving the higher level name space? Then it should be outside of mesos::internal as well!
- Bernd Mathiske
On Jan. 15, 2015, 9:46 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29930/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 9:46 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Niklas Nielsen.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/allocation/allocator.hpp PRE-CREATION
> src/allocation/drf_sorter.hpp PRE-CREATION
> src/allocation/drf_sorter.cpp PRE-CREATION
> src/allocation/hierarchical_allocator.hpp PRE-CREATION
> src/allocation/sorter.hpp PRE-CREATION
> src/local/local.hpp 0aa50ef
> src/local/local.cpp 76e73a4
> src/master/main.cpp e5e76ce
> src/master/master.hpp a8ce4d0
> src/master/master.cpp e9dcca3
> src/tests/cluster.hpp 74cedb3
> src/tests/fault_tolerance_tests.cpp 5763486
> src/tests/hierarchical_allocator_tests.cpp 7c05123
> src/tests/master_allocator_tests.cpp 2430622
> src/tests/master_authorization_tests.cpp 42ffe24
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 591134b
> src/tests/mesos.cpp 3b98c69
> src/tests/partition_tests.cpp fea7801
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp d098e70
> src/tests/slave_recovery_tests.cpp 809822e
> src/tests/sorter_tests.cpp 56e5714
>
> Diff: https://reviews.apache.org/r/29930/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29930: Cleaned up namespace hierarchy in allocation
sources.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29930/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 5:46 p.m.)
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Changes
-------
Rebase.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/allocation/allocator.hpp PRE-CREATION
src/allocation/drf_sorter.hpp PRE-CREATION
src/allocation/drf_sorter.cpp PRE-CREATION
src/allocation/hierarchical_allocator.hpp PRE-CREATION
src/allocation/sorter.hpp PRE-CREATION
src/local/local.hpp 0aa50ef
src/local/local.cpp 76e73a4
src/master/main.cpp e5e76ce
src/master/master.hpp a8ce4d0
src/master/master.cpp e9dcca3
src/tests/cluster.hpp 74cedb3
src/tests/fault_tolerance_tests.cpp 5763486
src/tests/hierarchical_allocator_tests.cpp 7c05123
src/tests/master_allocator_tests.cpp 2430622
src/tests/master_authorization_tests.cpp 42ffe24
src/tests/master_tests.cpp 678d27f
src/tests/mesos.hpp 591134b
src/tests/mesos.cpp 3b98c69
src/tests/partition_tests.cpp fea7801
src/tests/rate_limiting_tests.cpp 7f5ca25
src/tests/resource_offers_tests.cpp d098e70
src/tests/slave_recovery_tests.cpp 809822e
src/tests/sorter_tests.cpp 56e5714
Diff: https://reviews.apache.org/r/29930/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov