You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/03/10 04:51:00 UTC

[jira] [Work logged] (HIVE-24791) Backward compatibility issue in _dumpmetadata

     [ https://issues.apache.org/jira/browse/HIVE-24791?focusedWorklogId=563493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-563493 ]

ASF GitHub Bot logged work on HIVE-24791:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Mar/21 04:50
            Start Date: 10/Mar/21 04:50
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #1988:
URL: https://github.com/apache/hive/pull/1988#discussion_r591034982



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -203,7 +204,7 @@ private void initializeIfNot() throws SemanticException {
     }
   }
 
-  private List<String> prepareReplScopeValues() {
+  public List<String> prepareReplScopeValues() {

Review comment:
       why is this needed?

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java
##########
@@ -38,7 +38,7 @@
 public class DumpMetaData {
   // wrapper class for reading and writing metadata about a dump
   // responsible for _dumpmetadata files
-  private static final String DUMP_METADATA = "_dumpmetadata";
+  public static final String DUMP_METADATA = "_dumpmetadata";

Review comment:
       why is this needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 563493)
    Time Spent: 40m  (was: 0.5h)

> Backward compatibility issue in _dumpmetadata
> ---------------------------------------------
>
>                 Key: HIVE-24791
>                 URL: https://issues.apache.org/jira/browse/HIVE-24791
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Arko Sharma
>            Assignee: Arko Sharma
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-24791.01.patch, HIVE-24791.03.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)