You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Avinash Sridharan (JIRA)" <ji...@apache.org> on 2017/03/31 20:58:41 UTC

[jira] [Assigned] (MESOS-7304) Fetcher should not depends on SlaveID.

     [ https://issues.apache.org/jira/browse/MESOS-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Avinash Sridharan reassigned MESOS-7304:
----------------------------------------

    Assignee: Joseph Wu

> Fetcher should not depends on SlaveID.
> --------------------------------------
>
>                 Key: MESOS-7304
>                 URL: https://issues.apache.org/jira/browse/MESOS-7304
>             Project: Mesos
>          Issue Type: Task
>          Components: containerization, fetcher
>            Reporter: Jie Yu
>            Assignee: Joseph Wu
>
> Currently, various Fetcher interfaces depends on SlaveID, which is an unnecessary coupling. For instance:
> {code}
> Try<Nothing> Fetcher::recover(const SlaveID& slaveId, const Flags& flags);
> Future<Nothing> Fetcher::fetch(
>     const ContainerID& containerId,
>     const CommandInfo& commandInfo,
>     const string& sandboxDirectory,
>     const Option<string>& user,
>     const SlaveID& slaveId,
>     const Flags& flags);
> {code}
> Looks like the only reason we need a SlaveID is because we need to calculate the fetcher cache directory based on that. We should calculate the fetcher cache directory in the caller and pass that directory to Fetcher.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)