[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2255: Removed java.platform dependency from the Gradle Projects module

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2255:
URL: https://github.com/apache/netbeans/pull/2255#discussion_r454486647



##########
File path: extide/gradle/nbproject/project.xml
##########
@@ -139,15 +139,6 @@
                         <specification-version>1.41.1</specification-version>
                     </run-dependency>
                 </dependency>
-                <dependency>

Review comment:
       OK.

##########
File path: extide/gradle/nbproject/org-netbeans-modules-gradle.sig
##########
@@ -1,1074 +0,0 @@
-#Signature file v4.1
-#Version 2.0
-

Review comment:
       I don't think you want to completely remove the file. You may want to remove just the lines that are no longer present.

##########
File path: extide/gradle/manifest.mf
##########
@@ -1,6 +1,6 @@
 Manifest-Version: 1.0
 AutoUpdate-Show-In-Client: false
-OpenIDE-Module: org.netbeans.modules.gradle/2

Review comment:
       I suggest to keep the removed methods around, just deprecated. Then you don't have to increment the release version and you can stick with `/2`.
   
   Btw. the methods could even delegate to some provider to work the same way that did so far...

##########
File path: extide/gradle/src/org/netbeans/modules/gradle/api/execute/RunUtils.java
##########
@@ -347,41 +337,6 @@ public static ReplaceTokenProvider simpleReplaceTokenProvider(final String token
         };
     }
 
- /**
-     * Returns the active platform used by the project or null if the active
-     * project platform is broken.
-     * @param activePlatformId the name of platform used by Ant script or null
-     * for default platform.
-     * @return active {@link JavaPlatform} or null if the project's platform
-     * is broken
-     */
-    public static Pair<String, JavaPlatform> getActivePlatform(final String activePlatformId) {

Review comment:
       You can keep these two methods around, just `@deprecated`. Change the return type to `Pair` - e.g. the raw type. JVM is going to link to these two methods without a problem. See more in my [erasure](http://wiki.apidesign.org/wiki/Erasure) blog post.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists