You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/16 03:25:40 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #49: =str Avoid sub materialization in lazySingle.
He-Pin opened a new pull request, #49:
URL: https://github.com/apache/incubator-pekko/pull/49
refs: https://github.com/apache/incubator-pekko/issues/46
There is already a PR in akka , which using `single(()).map(_ => create())` I think which is simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1023475201
##########
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
+ */
Review Comment:
could you put Apache license on new files?
```
/*
* ====================================================================
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ====================================================================
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#issuecomment-1332389187
@He-Pin You need to rebase this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1023489557
##########
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
+ */
Review Comment:
there is no action for #38 - the requirement is to keep Lightbend headers on existing files but to add Apache licenses on new files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1023481108
##########
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
+ */
Review Comment:
I will check the header template then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #49: =str Avoid sub materialization in lazySingle.
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1023481108
##########
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
+ */
Review Comment:
I will check the header template then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1023486030
##########
akka-stream/src/main/scala/akka/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright (C) 2022 Lightbend Inc. <https://www.lightbend.com>
+ */
Review Comment:
Will resolved after https://github.com/apache/incubator-pekko/issues/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #49: =str Avoid sub materialization in lazySingle.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#issuecomment-1657799923
@He-Pin Do you want to look into this now that we are on 1.1.x series? Also if possible and easy to do so would it be possible to add a benchmark in https://github.com/apache/incubator-pekko/tree/b0fdac259bd57fdd481483f3fe9a7aec6e1ff38a/bench-jmh/src/main/scala/org/apache/pekko/stream ? While I am sure that you version has better performance, the adding of the benchmark is to prevent any potential future performance regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #49: =str Avoid sub materialization in lazySingle.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #49:
URL: https://github.com/apache/incubator-pekko/pull/49#discussion_r1278878579
##########
stream/src/main/scala/org/apache/pekko/stream/impl/fusing/LazySingleSource.scala:
##########
@@ -0,0 +1,50 @@
+/*
Review Comment:
This header file is a slightly different variant compared to what else is in Pekko, see https://github.com/apache/incubator-pekko/blob/bd9ff4da5bb59234c39af8916fb7a06caa755052/project/AddMetaInfLicenseFiles.scala#L1-L16 for the correct version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org