[GitHub] [incubator-doris] morningman commented on a diff in pull request #9670: [style](fe) code correct rules and name rules

[GitBox <gi...@apache.org>]

morningman commented on code in PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#discussion_r876081224


##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/util/LoadSubmitter.java:
##########
@@ -151,22 +151,22 @@ private Backend selectOneBackend() throws LoadException {
     }
 
     public static class SubmitResult {
-        public String TxnId;
-        public String Label;
-        public String Status;
-        public String ExistingJobStatus;
-        public String Message;
-        public String NumberTotalRows;
-        public String NumberLoadedRows;
-        public String NumberFilteredRows;
-        public String NumberUnselectedRows;
-        public String LoadBytes;
-        public String LoadTimeMs;
-        public String BeginTxnTimeMs;
-        public String StreamLoadPutTimeMs;
-        public String ReadDataTimeMs;
-        public String WriteDataTimeMs;
-        public String CommitAndPublishTimeMs;
-        public String ErrorURL;
+        public String txnId;

Review Comment:
   You can't change this.
   These name must match the name in json, case sensitive.



##########
fe/fe-core/src/main/java/org/apache/doris/ha/BdbHA.java:
##########
@@ -40,14 +40,14 @@
 import java.util.List;
 import java.util.Set;
 
-public class BDBHA implements HAProtocol {

Review Comment:
   How about not rename this file?



##########
fe/fe-core/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java:
##########
@@ -81,7 +81,7 @@ public class MaterializedViewSelector {
     //    private Map<String, Set<AggregatedColumn>> aggregateColumnsInQuery = Maps.newHashMap();
     private Map<Long, Set<String>> columnNamesInQueryOutput = Maps.newHashMap();
 
-    private boolean disableSPJGView;

Review Comment:
   not change it.



##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -320,30 +321,30 @@ public void init(Analyzer analyzer) {
     }
 
     protected void toThrift(TPlanNode msg, TPlanNodeType nodeType) {
-        Preconditions.checkState( materializedResultExprLists_.size() == children.size());

Review Comment:
   still a checkstyle warning here?



##########
fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BdbjeJournal.java:
##########
@@ -55,8 +55,8 @@
  * Finally, close this journal.
  * This class encapsulates the read, write APIs of bdbje
  */
-public class BDBJEJournal implements Journal {

Review Comment:
   How about not rename this file?



##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/BdbjeProcDir.java:
##########
@@ -29,7 +29,7 @@
 import java.util.TreeMap;
 
 // SHOW PROC "/bdbje"
-public class BDBJEProcDir implements ProcDirInterface  {

Review Comment:
   How about not rename this file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org