You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by matyapiro31 <gi...@git.apache.org> on 2016/04/15 19:11:47 UTC
[GitHub] thrift pull request: Fix command option error.
GitHub user matyapiro31 opened a pull request:
https://github.com/apache/thrift/pull/988
Fix command option error.
There's no --dbg for dh_strip, maybe someone has mistaken this for --dbg-package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matyapiro31/thrift matyapiro31-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #988
----
commit 547fcae26ff5bb67961bd5d2c45092303a9bf600
Author: Akira <ma...@users.noreply.github.com>
Date: 2016-04-15T17:09:49Z
Fix command option error.
There's no --dbg for dh_strip, maybe someone has mistaken this for --dbg-package.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/988#issuecomment-213107814
@matyapiro31, may I ask you to file a JIRA ticket for this, according to [our contrib guidelines](http://thrift.apache.org/docs/HowToContribute)? Or do we have one already maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/988#discussion_r59993662
--- Diff: debian/rules ---
@@ -199,8 +199,8 @@ binary-common:
dh_installexamples
dh_installman
dh_link
- dh_strip -ppython-thrift --dbg=python-thrift-dbg
- dh_strip -ppython3-thrift --dbg=python3-thrift-dbg
+ dh_strip -ppython-thrift --dbg-package=python-thrift-dbg
+ dh_strip -ppython3-thrift --dbg-package=python3-thrift-dbg
--- End diff --
@nsuke: any comments from your side?
this is from f43d0ca6e57c4c30ea742e5f80e086288e999ecb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/988#discussion_r59995093
--- Diff: debian/rules ---
@@ -199,8 +199,8 @@ binary-common:
dh_installexamples
dh_installman
dh_link
- dh_strip -ppython-thrift --dbg=python-thrift-dbg
- dh_strip -ppython3-thrift --dbg=python3-thrift-dbg
+ dh_strip -ppython-thrift --dbg-package=python-thrift-dbg
+ dh_strip -ppython3-thrift --dbg-package=python3-thrift-dbg
--- End diff --
Actually, -dbg= was from original line from THRIFT-71.
I don't know much about this but seeing the doc it seems this fix seems correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by matyapiro31 <gi...@git.apache.org>.
Github user matyapiro31 commented on the pull request:
https://github.com/apache/thrift/pull/988#issuecomment-213199259
@Jens-G What do you mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/988#issuecomment-213571065
tracked in THRIFT-3796
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix command option error.
Posted by matyapiro31 <gi...@git.apache.org>.
Github user matyapiro31 commented on the pull request:
https://github.com/apache/thrift/pull/988#issuecomment-210936265
These build failures don't come from my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---