You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Chuan Lei <le...@gmail.com> on 2013/08/08 03:52:19 UTC
Review Request 13399: GiraphApplicationMaster race condition in resource
loading
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13399/
-----------------------------------------------------------
Review request for giraph and Avery Ching.
Bugs: GIRAPH-730
https://issues.apache.org/jira/browse/GIRAPH-730
Repository: giraph-git
Description
-------
In GiraphApplicationMaster.java, getTaskResourceMap function is not multi-thread safe, which causes the application master fail to distribute the resources (jar, configuration file, etc.) to each container.
Diffs
-----
giraph-core/src/main/java/org/apache/giraph/yarn/GiraphApplicationMaster.java c2b88a0
Diff: https://reviews.apache.org/r/13399/diff/
Testing
-------
Thanks,
Chuan Lei
Re: Review Request 13399: GiraphApplicationMaster race condition in resource
loading
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13399/#review25462
-----------------------------------------------------------
This looks good to be, but I am not that familiar with the YARN code. Eli, any comments?
- Avery Ching
On Aug. 8, 2013, 1:52 a.m., Chuan Lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13399/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 1:52 a.m.)
>
>
> Review request for giraph and Avery Ching.
>
>
> Bugs: GIRAPH-730
> https://issues.apache.org/jira/browse/GIRAPH-730
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> In GiraphApplicationMaster.java, getTaskResourceMap function is not multi-thread safe, which causes the application master fail to distribute the resources (jar, configuration file, etc.) to each container.
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/yarn/GiraphApplicationMaster.java c2b88a0
>
> Diff: https://reviews.apache.org/r/13399/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chuan Lei
>
>