You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/17 09:08:43 UTC

[GitHub] flink pull request #4557: [hotifx][streaming] Simplify state of TwoPhaseComm...

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4557

    [hotifx][streaming] Simplify state of TwoPhaseCommitSinkFunction

    This simplify state of `TwoPhaseCommitSinkFunction`, by dropping unnecessary complication.
    
    This change is already covered by existing tests, such as *TwoPhaseCommitSinkFunctionTest*.
    
    It changes the public API annotated with `@PublicEvolving` (different constructor parameter) 
    and it changes the way how `TwoPhaseCommitSinkFunction` is serialized on checkpoints/savepoints. However this code has not been released yet anywhere.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink 2phase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4557
    
----
commit 454a1ead00bcd5d255ea482ef0d1e847cb1061f9
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-08-14T14:40:45Z

    [hotifx][streaming] Simplify state of TwoPhaseCommitSinkFunction

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4557
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4557
  
    Ok, I will create JIRA issues for such things in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/4557
  
    This LGTM, +1.
    Merging this ..
    
    Minor nitpick for the future: I think although this is a small fix, the nature of the fix still deserves a dedicated JIRA ticket for it. Hotfixes, AFAIK, are meant only for minor cosmetic refactorings or typos.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4557: [hotifx][streaming] Simplify state of TwoPhaseComm...

Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski closed the pull request at:

    https://github.com/apache/flink/pull/4557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4557
  
    Merged 👌 Could you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---