You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:03:40 UTC

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17483: Fix lint and types

ryanthompson591 commented on code in PR #17483:
URL: https://github.com/apache/beam/pull/17483#discussion_r860928841


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -44,10 +44,10 @@
 from apache_beam.utils import shared
 
 try:
-  # pylint: disable=g-import-not-at-top
+  # pylint: disable=wrong-import-order, wrong-import-position
   import resource
 except ImportError:
-  resource = None
+  resource = None  # type: ignore[assignment]

Review Comment:
   I think this might work if we replace this with pass, and we wouldn't need the lint exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org