[GitHub] [age] TropicalPenguin commented on pull request #349: Issue 317: Graph naming convention

[GitBox <gi...@apache.org>]

TropicalPenguin commented on PR #349:
URL: https://github.com/apache/age/pull/349#issuecomment-1312316175

   I see two main issues with the proposed regex matching:
   
   1. It will fail for alphabetic characters outside the basic Latin alphabet. I think it's important to support a far broader sweep of Unicode code points, to allow internationalised graph content.
   > This includes "non-English" characters, such as å, ä, ö, ü etc.
   2. It doesn't permit backtick specification of non-alphabetic strings:
   > Non-alphabetic characters, including numbers, symbols and whitespace characters, can be used in names, but must be escaped using backticks. For example: `^n`, `1first`, `$$n`, and `my variable has spaces`. Database names are an exception and may include dots without the need for escaping. For example: naming a database foo.bar.baz is perfectly valid.
   
   Have quoted those side-comments from the Neo4J docs: https://neo4j.com/docs/cypher-manual/current/syntax/naming/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org