You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@climate.apache.org by huikyole <gi...@git.apache.org> on 2018/01/22 01:38:50 UTC

[GitHub] climate pull request #496: CLIMATE-947 - Updates in cordex.py

GitHub user huikyole opened a pull request:

    https://github.com/apache/climate/pull/496

    CLIMATE-947 - Updates in cordex.py

    The goal of this PR is to facilitate building a RCMES docker image.
    
      - The variable 'errored' is defined outside a for loop.
       - domain, workdir, obs_dir, and models_dir can be sys.argv


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huikyole/climate CLIMATE-947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #496
    
----
commit c2ca575d194fe90f1550a065c7646836780441e7
Author: huikyole <hu...@...>
Date:   2018-01-22T01:30:12Z

    CLIMATE-947 - Updates in cordex.py

----


---

[GitHub] climate pull request #496: CLIMATE-947 - Updates in cordex.py

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/climate/pull/496


---

[GitHub] climate issue #496: CLIMATE-947 - Updates in cordex.py

Posted by huikyole <gi...@git.apache.org>.

Github user huikyole commented on the issue:

    https://github.com/apache/climate/pull/496
  
    @agoodm I had to run dos2unix first to remove ^M characters. Could you review this PR?


---

[GitHub] climate issue #496: CLIMATE-947 - Updates in cordex.py

Posted by agoodm <gi...@git.apache.org>.

Github user agoodm commented on the issue:

    https://github.com/apache/climate/pull/496
  
    LGTM 👍 


---